Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcAvatar): implement custom javascript hook action for the contacts menu #6238

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat(NcAvatar): implement custom javascript hook action for the contacts menu #6238

merged 1 commit into from
Dec 17, 2024

Conversation

st3iny
Copy link
Contributor

@st3iny st3iny commented Nov 19, 2024 •
edited
Loading

☑️ Resolves

📒 Description

Adds a new contacts menu that is able to trigger hooks registered via registerContactsMenuAction("foo-bar").

export interface ContactsMenuAction {
	id: string,
	displayName: (entry: ContactsMenuEntry) => string,
	enabled: (entry: ContactsMenuEntry) => boolean,
	iconSvg: (entry: ContactsMenuEntry) => string,
	callback: (entry: ContactsMenuEntry) => void,
}

🖼️ Screenshots

Nothing really to show here. Please have a look here for an implementation.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@st3iny st3iny added enhancement New feature or request 2. developing Work in progress feature: avatar Related to the avatar component feature: functions composables, functions, mixins and other non-components labels Nov 19, 2024
@st3iny st3iny self-assigned this Nov 19, 2024
This was referenced Nov 19, 2024
Open
Open
@st3iny st3iny marked this pull request as ready for review November 26, 2024 20:45
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 26, 2024
ChristophWurst
ChristophWurst approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/functions/contactsMenu/index.ts Outdated Show resolved Hide resolved
@st3iny st3iny requested a review from GretaD December 16, 2024 16:08
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 17, 2024
@st3iny st3iny force-pushed the feat/NcAvatar/js-hook-action branch from 522a3db to e4d7568 Compare December 17, 2024 10:38
@st3iny
Copy link
Contributor Author

st3iny commented Dec 17, 2024

/backport to next

@st3iny st3iny enabled auto-merge December 17, 2024 10:39
@st3iny st3iny merged commit 4ceb79c into master Dec 17, 2024
19 checks passed
@st3iny st3iny deleted the feat/NcAvatar/js-hook-action branch December 17, 2024 10:40
@backportbot backportbot bot mentioned this pull request Dec 17, 2024
Draft
2 tasks
@hamza221 hamza221 mentioned this pull request Dec 20, 2024
Merged
@ShGKme ShGKme mentioned this pull request Dec 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@susnux susnux Awaiting requested review from susnux

@ShGKme ShGKme Awaiting requested review from ShGKme

@GretaD GretaD Awaiting requested review from GretaD

Assignees

@st3iny st3iny

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request feature: avatar Related to the avatar component feature: functions composables, functions, mixins and other non-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@st3iny @ChristophWurst @susnux @skjnldsv