Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(NcSettingsSection): Add RTL support to NcSettingsSection info icon. #6290

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix(NcSettingsSection): Add RTL support to NcSettingsSection info icon. #6290

merged 2 commits into from
Dec 20, 2024

Conversation

falghamdi125
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

Best

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: settings Related to the settings component RTL Right-to-Left languages support labels Dec 20, 2024
@Antreesy Antreesy added this to the 8.21.1 milestone Dec 20, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.26%. Comparing base (2ed3522) to head (0d3715f).
Report is 16 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6290      +/-   ##
==========================================
- Coverage   42.30%   42.26%   -0.04%     
==========================================
  Files         154      155       +1     
  Lines        3988     3996       +8     
  Branches     1023     1001      -22     
==========================================
+ Hits         1687     1689       +2     
- Misses       2190     2199       +9     
+ Partials      111      108       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221
Copy link
Contributor

/backport to next

@nickvergessen nickvergessen merged commit 038d599 into nextcloud-libraries:master Dec 20, 2024
16 of 17 checks passed
@backportbot backportbot bot mentioned this pull request Dec 20, 2024
Merged
@hamza221 hamza221 mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@hamza221 hamza221 hamza221 approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: settings Related to the settings component RTL Right-to-Left languages support
Projects
None yet
Milestone
8.21.1
Development

Successfully merging this pull request may close these issues.
4 participants
@falghamdi125 @hamza221 @Antreesy @nickvergessen