Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDateTimePicker): popup position #6312

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(NcDateTimePicker): popup position #6312

merged 1 commit into from
Dec 19, 2024

Conversation

hamza221
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels Dec 19, 2024
@hamza221 hamza221 requested review from GretaD and Antreesy December 19, 2024 10:27
@hamza221 hamza221 self-assigned this Dec 19, 2024
@hamza221 hamza221 requested a review from elzody December 19, 2024 10:28
@hamza221
Copy link
Contributor Author

caused by https://github.com/nextcloud-libraries/nextcloud-vue/pull/6095/files#diff-e5f5a0a15c6bd5c6f28e5e18f5bd3c0d0de41de389f50b71b15ff5e8245f9536R55

Antreesy
Antreesy approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why it was introduced in the first place, but makes sense, as lib defines it
image

@ShGKme
Copy link
Contributor

ShGKme commented Dec 19, 2024

/backport to next

@ShGKme ShGKme added this to the 8.21.1 milestone Dec 19, 2024
@hamza221 hamza221 merged commit 81927a5 into master Dec 19, 2024
19 checks passed
@hamza221 hamza221 deleted the fix/datepicker/position branch December 19, 2024 16:03
@backportbot backportbot bot mentioned this pull request Dec 19, 2024
Merged
@hamza221 hamza221 mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme ShGKme approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@elzody elzody Awaiting requested review from elzody

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
8.21.1
Development

Successfully merging this pull request may close these issues.

Date picker is way out of position
3 participants
@hamza221 @ShGKme @Antreesy