Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone cards together with the board #3430

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Clone cards together with the board #3430

merged 1 commit into from
Jan 2, 2025
+406 −108

Conversation

bahuma20
Copy link
Contributor

@bahuma20 bahuma20 commented Nov 18, 2021 •
edited by juliusknorr
Loading

Summary

Description Screenshot
Add the possibility to clone cards together with the board. image
Also allow customizations when cloning. image
In advanced options, cards can be moved to the first list and archived cards can be restored. image

Follow Up

  • Copy attachments
  • Copy comments

TODO

  • Write tests (I need help here, i don't know how to do this in Nextcloud)
  • Maybe adjust documentation. Right now only REST api doc was updated.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@stefan-niedermann
Copy link
Member

  1. We should use one term (clone or copy)
  2. Copy assignments, labels and due dates should be checked by default in my opinion
  3. @juliushaertl do we really want the other two checkboxes? I consider them being edge cases, but at least they should be visually seperated from the others because they have another context and are some kind of "destructive" (they "change" or "modify" the data whole copying)

@juliusknorr juliusknorr self-requested a review November 24, 2021 15:09
@danir-de
Copy link

  1. @juliushaertl do we really want the other two checkboxes? I consider them being edge cases, but at least they should be visually seperated from the others because they have another context and are some kind of "destructive" (they "change" or "modify" the data whole copying)

Restoring archived cards would in no way be an edge case!
People use deck cloning to create a complex deck preset they can clone for repeating projects/tasks.

@juliusknorr juliusknorr added this to the 1.7.0 milestone Dec 27, 2021
@juliusknorr
Copy link
Member

Hello @bahuma20. I'm very sorry for the long delay on the feedback of this one, we'll have a look into it soonish to get this merged.

luka-nextcloud
luka-nextcloud reviewed Apr 21, 2022
View reviewed changes
lib/Service/BoardService.php Outdated
@@ -80,11 +85,13 @@ class BoardService {
public function __construct(
BoardMapper $boardMapper,
StackMapper $stackMapper,
CardMapper $cardMapper,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 2 injections of CardMapper, see below at line 97.

luka-nextcloud
luka-nextcloud reviewed Apr 21, 2022
View reviewed changes
lib/Service/BoardService.php
@@ -662,6 +672,16 @@ public function clone($id, $userId) {
]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can separate the board cloning logics in a different class - The BoardMapper or the Service.

luka-nextcloud
luka-nextcloud reviewed Apr 21, 2022
View reviewed changes
tests/unit/Service/BoardServiceTest.php Outdated
@@ -103,11 +107,13 @@ public function setUp(): void {
$this->service = new BoardService(
$this->boardMapper,
$this->stackMapper,
$this->cardMapper,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two CardMapper usages in the BoardService constructor.

@jancborchardt
Copy link
Member

  1. We should use one term (clone or copy)

Agree with @stefan-niedermann – we should use Copy everywhere since that is the more commonly used word.

@danir-de
Copy link

  1. We should use one term (clone or copy)
    Agree with @stefan-niedermann – we should use Copy everywhere since that is the more commonly used word.

Yes but Copy often requires pasting something and/or choosing where to copy it to.
Clone on the other hand is mostly used to create a copy (a clone) to the exact same location.

I'd say that Clone or Duplicate would be way more fitting than Copy.

@juliusknorr juliusknorr mentioned this pull request Apr 25, 2022
Closed
4 tasks
@small1
Copy link
Contributor

small1 commented Dec 13, 2022

This would be nice to have merged. This would solve a problem for a few projects where they have asked for this type of feature.

@juliusknorr
Copy link
Member

I rebased this as there were quite some conflicting changes. Will have a look what is missing to get this in.

@juliusknorr juliusknorr self-assigned this Oct 25, 2023
@putt1ck putt1ck mentioned this pull request Dec 9, 2023
Open
@juliusknorr juliusknorr assigned grnd-alt and unassigned juliusknorr May 16, 2024
@grnd-alt grnd-alt force-pushed the 2797-clone-cards branch 3 times, most recently from 4ce2d79 to 0473133 Compare May 24, 2024 13:45
luka-nextcloud
luka-nextcloud reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@luka-nextcloud luka-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cypress tests should be added.

@cyrillappert
Copy link

cyrillappert commented Sep 12, 2024 •
edited
Loading

We would also be very interested in this feature.

@TheBestDestroyer
Copy link

I would also be very interested in this feature. Why it has not been merged yet?

@juliusknorr juliusknorr requested a review from elzody as a code owner January 2, 2025 15:36
@bahuma20 @juliusknorr
feat: Add possibility to clone cards when cloning a board
f2c30af 
Signed-off-by: Max Bachhuber <[email protected]>

Adjust BoardServiceTest to new dependencies

Signed-off-by: Max Bachhuber <[email protected]>

Add BoardCloneModal vue component to frontend. Adjust BoardApi and store to support clone options

Signed-off-by: Max Bachhuber <[email protected]>

Add license and credits

Signed-off-by: Max Bachhuber <[email protected]>

Fix PHP code style

Signed-off-by: Max Bachhuber <[email protected]>

Change default clone settings

Signed-off-by: Max Bachhuber <[email protected]>

Add accordion for advanced settings

Signed-off-by: Max Bachhuber <[email protected]>

Fix bug which caused board to be cloned when clicking out of the modal

Signed-off-by: Max Bachhuber <[email protected]>

Change wording of clone options

Signed-off-by: Max Bachhuber <[email protected]>

fix: Rebase failures

Signed-off-by: Julius Härtl <[email protected]>

update cloneBoards phpdoc

make error message clear

SPDX Header BoardCloneModal.vue

Signed-off-by: grnd-alt <[email protected]>
@juliusknorr
Copy link
Member

Pushed some tests and fixed remaining review comments where reasonable.

I'll get this merged for now even if we lack attachment and comment cloning. I think this is valuable enough without so we can get this unblocked.

@juliusknorr juliusknorr merged commit 0527743 into nextcloud:main Jan 2, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luka-nextcloud luka-nextcloud luka-nextcloud left review comments

@grnd-alt grnd-alt grnd-alt left review comments

@juliusknorr juliusknorr juliusknorr approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@elzody elzody Awaiting requested review from elzody elzody is a code owner

Assignees

@grnd-alt grnd-alt

Labels
2. developing enhancement
Projects
📝 Office team
Status: ☑️ Done
Milestone
1.10.0 (Nextcloud 27)
Development

Successfully merging this pull request may close these issues.

duplicating a board copies its lists, but not the cards
10 participants
@bahuma20 @stefan-niedermann @danir-de @juliusknorr @jancborchardt @small1 @cyrillappert @TheBestDestroyer @grnd-alt @luka-nextcloud