Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable WEBP support #785

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Enable WEBP support #785

merged 1 commit into from
Jun 27, 2019

Conversation

Flow86
Copy link
Contributor

@Flow86 Flow86 commented Jun 26, 2019

Enable WEBP support in GD module, so that processing webp files in nextcloud will work.

I created a small app https://github.com/Flow86/preview_webp to allow preview of webp files in nextcloud file browser.

@J0WI
Copy link
Contributor

J0WI commented Jun 26, 2019

This is a tricky one. Normally we use example Dockerfiles to support additional apps.
But in this case we can't extend the already compiled GD extension.

I just asked for upstream support in nextcloud/server#13552 (comment). @tilosp would you agree to extend the GD extension for WebP support?

Copy link
Contributor

@J0WI J0WI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the corresponding dependency to the Alpine variant:

docker-php-ext-configure gd --with-freetype-dir=/usr --with-png-dir=/usr --with-jpeg-dir=/usr; \

@J0WI J0WI added the image label Jun 26, 2019
@Flow86 Flow86 force-pushed the add-webp-support branch from 4ba9e2a to 11cc51e Compare June 26, 2019 15:33
@Flow86
Copy link
Contributor Author

Flow86 commented Jun 27, 2019

Please also add the corresponding dependency to the Alpine variant

Done in 11cc51e

Copy link
Member

@tilosp tilosp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tilosp would you agree to extend the GD extension for WebP support?

yes adding support for WebP is fine, especially since it only adds <1MB.

@J0WI J0WI merged commit f5665e1 into nextcloud:master Jun 27, 2019
@J0WI
Copy link
Contributor

J0WI commented Jun 27, 2019

Thanks!

@Flow86 Flow86 deleted the add-webp-support branch June 27, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants