Skip to content

Commit

Permalink
Merge pull request #2253 from nextcloud/backport/2249/stable28
Browse files Browse the repository at this point in the history
[stable28] Clean up headings
  • Loading branch information
JuliaKirschenheuter authored Jan 15, 2024
2 parents e75bee2 + b86c1ba commit c869e4a
Show file tree
Hide file tree
Showing 26 changed files with 44 additions and 48 deletions.
4 changes: 2 additions & 2 deletions js/photos-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-main.js.map

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-public.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-public.js.map

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-src_views_AlbumContent_vue.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-src_views_AlbumContent_vue.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-src_views_Albums_vue.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-src_views_Albums_vue.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/photos-src_views_Folders_vue.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/photos-src_views_Folders_vue.js.map

Large diffs are not rendered by default.

9 changes: 1 addition & 8 deletions src/Photos.vue
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
</div>
</template>
</NcAppNavigation>
<NcAppContent :page-heading="pageHeading">
<NcAppContent>
<RouterView />

<!-- svg img loading placeholder (linked to the File component) -->
Expand Down Expand Up @@ -201,13 +201,6 @@ export default {
openedSettings: false,
}
},

computed: {
pageHeading() {
return this.$route.meta.rootTitle?.(this.$route)
},
},

async beforeMount() {
// Register excluded paths
const files = loadState('photos', 'nomedia-paths', [])
Expand Down
11 changes: 7 additions & 4 deletions src/components/HeaderNavigation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@

<!-- Main Navigation title -->
<div class="photos-navigation__title">
<h2 class="photos-navigation__title__main" @click="refresh">
<h1 class="photos-navigation__title__main" @click="refresh">
{{ name }}
</h2>
</h1>
<div class="photos-navigation__title__sub" />
<slot name="subtitle" />
</div>
Expand Down Expand Up @@ -204,7 +204,7 @@ button.app-navigation-toggle {
align-items: center;
width: 100%;
min-height: var(--photos-navigation-height);
padding: 0 var(--photos-navigation-height);
padding: 15px var(--photos-navigation-height) 0 var(--photos-navigation-height);
background: var(--color-main-background);

&__back {
Expand All @@ -221,8 +221,11 @@ button.app-navigation-toggle {
flex-direction: column;

&__main {
margin: 0;
cursor: pointer;
font-weight: 700;
font-size: 20px;
line-height: 44px;
margin: 0 0 0 calc(2 * var(--app-navigation-padding, 8px) + 44px);
}

&__main, &__sub {
Expand Down

0 comments on commit c869e4a

Please sign in to comment.