Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload an image to an album #2192

Closed
wants to merge 3 commits into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 12, 2023

Resolves: #2191

Before the "Add" button on the Files Picker uploaded files via /dav/files API for further manual selecting and adding.

  • This was inconsistent with the "Upload files" button and "Add photos to this album menu" action (because it only uploaded files_
  • For the first uploaded photos it failed, because /dav/files API is not creating photos directory as /dav/photos/ API

This PR makes this "Add" button work the same as the "Upload files" button and fixes the bug with the first image uploading.

BeforeAfter
Uploading the first file
Before-bug.mp4
after-no-bug.mp4
Uploading with old files
Before-old.mp4
After-old.mp4

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Dec 12, 2023
@ShGKme ShGKme added this to the Nextcloud 29 milestone Dec 12, 2023
@ShGKme ShGKme requested review from artonge, skjnldsv and Pytal December 12, 2023 20:09
@ShGKme ShGKme self-assigned this Dec 12, 2023
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme force-pushed the fix/2191/inconsistent-upload-to-album branch from 7e92f63 to 2245b6f Compare December 12, 2023 23:13
@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 12, 2023

/compile / amend

Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge closed this Dec 13, 2023
@artonge
Copy link
Collaborator

artonge commented Dec 13, 2023

See #2191 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload the first image to an album doesn't work
3 participants