-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Fatal Error in Album setCollaborator function - redefining computeKey function #2205
Conversation
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Thanks @frederikb96, can you fix the DCO? |
Thanks, I will look into it tomorrow 🙂 |
86b12e4
to
5cc4033
Compare
@artonge Ok, I guess that's it right (I am new to this :)), thanks. |
@frederikb96 Php cs is also red. Running |
…eKey When calling setCollaborator function two times after another, computeKey is redefined and leads to a fatal error. Fixed by defining it as an anonymous function instead :) Signed-off-by: Frederik Berg <[email protected]>
@artonge Ok php cs is fixed now :) |
Thanks a lot @frederikb96 ! |
When calling setCollaborator function two times after another, computeKey is redefined and leads to a fatal error. Fixed by defining it as an anonymous function instead :)
I wrote an app, which calls this function, and thus I discovered that problem.