Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the role img elements have aria label #2247

Closed
wants to merge 0 commits into from
Closed

Ensure that the role img elements have aria label #2247

wants to merge 0 commits into from

Conversation

GretaD
Copy link

@GretaD GretaD commented Jan 11, 2024

fixes #2240

@GretaD GretaD added 3. to review Waiting for reviews accessibility labels Jan 11, 2024
@GretaD GretaD self-assigned this Jan 11, 2024
@GretaD
Copy link
Author

GretaD commented Jan 11, 2024 •
edited
Loading

@JuliaKirschenheuter you wanted only this element to be changed, right? I checked other spans that had role=img, but they all have aria-label. If i need to check other elements, please let me know.

JuliaKirschenheuter
JuliaKirschenheuter approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greta

Please think about backport to stable28

@GretaD
Copy link
Author

GretaD commented Jan 16, 2024

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jan 16, 2024
@ChristophWurst
Copy link
Member

needs a rebase to resolve the conflicts

@ChristophWurst
Copy link
Member

/rebase

@ChristophWurst
Copy link
Member

needs a manual rebase :D

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 19, 2024
@GretaD
Copy link
Author

GretaD commented Jan 19, 2024

node is still not happy

@ChristophWurst
Copy link
Member

/compile amend /

@ChristophWurst
Copy link
Member

/compile amend /

@susnux susnux closed this Jan 23, 2024
auto-merge was automatically disabled January 23, 2024 17:54

Pull request was closed

@susnux
Copy link
Contributor

susnux commented Jan 23, 2024

I rebased and it was empty O.o

I guess because it was fixed with 0dc150b

@susnux susnux deleted the fix/aria-label branch January 23, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

Assignees

@GretaD GretaD

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility backport-request Pending backport by the backport-bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV]: Ensures [role="img"] elements have alternate text or hide it from a11y tree
4 participants
@GretaD @ChristophWurst @susnux @JuliaKirschenheuter