Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes in preparation of 30 #2514

Merged
merged 15 commits into from
Jul 4, 2024
Merged

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jul 3, 2024

Change Before After
fix: Limit upload picker custom css to header Screenshot 2024-07-03 at 17-58-55 Album aze3 - Photos - Nextcloud Screenshot 2024-07-03 at 17-52-42 Album aze3 - Photos - Nextcloud
dix: Populate photosLocationFolder on init Screenshot 2024-07-03 at 18-03-03 Album aze3 - Photos - Nextcloud Screenshot 2024-07-03 at 18-02-35 Album aze3 - Photos - Nextcloud
fix: Make route name unique Less warnings in browser console
chore: Fix typo in collection.js No more typo
chore: Use NcSelect label Less warnings in browser console and less custom code
fix: Don't proceed with album creation if it fails Prevents storing undefined in the albums store
chore: Explicitly require @nc/router Make linter happy
fix: Specify a source for the tmp local album Less warnings in browser console
fix: Declare photosLocationFolder as computed Fix uploading files from an album
fix: Check if album is defined before accessing it in AlbumContent Less errors in browser console
chore: Remove useless v-if in AlbumContent -
fix: Reinit the files in File.vue Fix rendering previews when adding a file to an album
fix: Center empty content in empty albums To make me happy
feat: Display the upload button for empty albums As it does not make sense to hide it in the first place

@artonge artonge self-assigned this Jul 3, 2024
@artonge artonge force-pushed the artonge/fix/smoke_test_fixes branch from ed7fb40 to df8c363 Compare July 3, 2024 13:12
@artonge artonge added bug Something isn't working javascript Javascript related ticket 2. developing Work in progress labels Jul 3, 2024
@artonge artonge added this to the Nextcloud 30 milestone Jul 3, 2024
@artonge artonge changed the title chore: Explicitly require @nc/router Various fixes in preparation for 30 Jul 3, 2024
@artonge artonge requested review from skjnldsv and susnux July 3, 2024 16:23
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 3, 2024
@artonge artonge changed the title Various fixes in preparation for 30 Various fixes in preparation of 30 Jul 3, 2024
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artonge artonge merged commit c51449a into master Jul 4, 2024
47 checks passed
@artonge artonge deleted the artonge/fix/smoke_test_fixes branch July 4, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants