Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Check upload directory share state #2657

Closed
wants to merge 1 commit into from
Closed

feat: Check upload directory share state #2657

wants to merge 1 commit into from

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Sep 25, 2024 •
edited by nickvergessen
Loading

Done:

  • Block upload to the album DAV endpoint if the current user does not own the photo folder.
  • Add warning in Photos picker dialog. An alternative would be to hide the button. But uploads cannot be blocked as they are done directly to the DAV files endpoint, so it is impossible to distinguish from a legitimate upload.

Screenshot from 2024-09-25 14-40-42

@artonge artonge requested a review from skjnldsv September 25, 2024 12:54
@artonge artonge force-pushed the artonge/fix/check_upload_folder_share_state branch from 8dec168 to 397aac2 Compare September 25, 2024 14:30
@artonge artonge self-assigned this Sep 25, 2024
@artonge artonge added enhancement New feature or request 3. to review Waiting for reviews php PHP related ticket javascript Javascript related ticket labels Sep 25, 2024
@artonge artonge added this to the Nextcloud 31 milestone Sep 25, 2024
@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable30

@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Sep 25, 2024
@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable28

@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable27

@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable26

@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable25

@artonge artonge force-pushed the artonge/fix/check_upload_folder_share_state branch from 397aac2 to 3d5562b Compare September 25, 2024 15:51
@artonge artonge mentioned this pull request Sep 25, 2024
Merged
@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

Closed in favor of local copy: #2658

@artonge artonge closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@provokateurin provokateurin provokateurin approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot enhancement New feature or request javascript Javascript related ticket php PHP related ticket
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @nickvergessen @provokateurin