Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dav): Add tests for dav interface to full-run-test.yml #1044

Merged
merged 17 commits into from
Dec 4, 2023

Conversation

marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Dec 1, 2023

fixes #1043

@pulsejet
Copy link
Member

pulsejet commented Dec 3, 2023

Fixes the DAV API for me. Just a note: I can't get anything to show up in the Photos app on stable28 + recognize with this patch. The list shows fine but nothing inside a person

EDIT: seems like a bug in Photos, so irrelevant here.

ConsoleLogger.js:59 [ERROR] photos: Error fetching face files {app: 'photos', uid: 'admin', level: 0, error: TypeError: Cannot read properties of undefined (reading 'replace')
    at Object.x (http://localhos…}app: "photos"error: TypeError: Cannot read properties of undefined (reading 'replace')
    at Object.x (http://localhost:8035/apps/photos/js/photos-main.js:2:1084987)
    at http://localhost:8035/apps/photos/js/photos-src_views_Faces_vue.js?v=c575b87798a3130e8fcb:2:2515
    at Array.map (<anonymous>)
    at o.fetchFaceContent (http://localhost:8035/apps/photos/js/photos-src_views_Faces_vue.js?v=c575b87798a3130e8fcb:2:2487)message: "Cannot read properties of undefined (reading 'replace')"stack: "TypeError: Cannot read properties of undefined (reading 'replace')\n    at Object.x (http://localhost:8035/apps/photos/js/photos-main.js:2:1084987)\n    at http://localhost:8035/apps/photos/js/photos-src_views_Faces_vue.js?v=c575b87798a3130e8fcb:2:2515\n    at Array.map (<anonymous>)\n    at o.fetchFaceContent (http://localhost:8035/apps/photos/js/photos-src_views_Faces_vue.js?v=c575b87798a3130e8fcb:2:2487)"[[Prototype]]: Errorconstructor: ƒ TypeError()message: ""name: "TypeError"[[Prototype]]: Objectlevel: 0uid: "admin"[[Prototype]]: Object
value @ ConsoleLogger.js:59
value @ ConsoleLogger.js:85
fetchFaceContent @ FetchFacesMixin.js:147
await in fetchFaceContent (async)
mounted @ FaceContent.vue:290
ln @ vue.runtime.esm.js:3017
Pn @ vue.runtime.esm.js:4031

Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
Copy link
Member Author

Hey @pulsejet
thanks for testing. I'm trying to fix the clustering end to end test right now, but can't for the life of me find the memory leak recorded in this profile: https://blackfire.io/profiles/f2045c46-af30-4ad7-a0d1-3f71cbd5d19a/graph Any help is appreciated.

@marcelklehr
Copy link
Member Author

Mh, 926f922 seems to have done the trick here in CI, even though it didn't in my tests.... Whatever...

@marcelklehr marcelklehr merged commit 59e972d into main Dec 4, 2023
43 checks passed
@marcelklehr marcelklehr deleted the fix/webdav-and-tests branch December 4, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving faces fails with NC28 RC2
2 participants