-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to @vladmandic/human #1218
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ghisch <[email protected]>
Adapt dimensions to 1024 as outputed by @vladmandic/human Signed-off-by: ghisch <[email protected]>
Signed-off-by: ghisch <[email protected]>
Signed-off-by: ghisch <[email protected]>
Thank you sooo much for this PR, I think this is strongly needed. The face-api Repo hasn't gotten a meaningful commit since January and is also Archived now. Hopefully @marcelklehr can look at this PR when he has time :) |
Hello @ghisch |
Hello @marcelklehr 👋 I totally understand no problem. Also, FYI, human lib repo also provide some kind of clustering in JS, I feel like inspiration can be taken from here. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This PR updates the face detection classifier from
@vladmandic/face-api
to@vladmandic/human
.Fix #1171
Key Changes
Improved Performance
@vladmandic/human
offers significantly better performance compared toface-api
, with faster processing and more reliable face detection.Configuration Adjustments
maxDetected
to 100 (default is 1) to support multiple faces in a single image.descriptor
(128 dimensions inface-api
), now calledembedding
(1024 dimensions inhuman
).Face Clustering
MIN_CLUSTER_SEPARATION
,MAX_CLUSTER_EDGE_LENGTH
) might need optimization for the new 1024-dimensional embeddings. Suggestions and assistance on tuning these are welcome! 🙏Compatibility Note
face-api
are incompatible withhuman
embeddings. This requires a reset of existing data to align with the new system.Testing
Request for Feedback
Recap (Help Needed 🙏)
Let me know if there's anything I can improve or clarify further!