-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close NC sidebar on file open #3259
Close NC sidebar on file open #3259
Conversation
65cb0fd
to
1930be4
Compare
@juliushaertl do we need backport to 27 and 26 as well ? |
Yes, but we can do this likely automatically once this one is merged. No need to manually prepare those for now. |
/backport to stable27 |
/backport to stable26 |
@Darshan-upadhyay1110 I also invited you to the repo so you can create branches directly here and CI will run automatically for future prs ;) |
@juliushaertl can we add comment in the main issue and do not close that ? as this is a temp fix so it is good to just let that issue open for more generic fix |
- For internal shared links of Office documents sidebar gets open by default - sidebar should not open at all when we click on document file or file gets opened by shared link Signed-off-by: Darshan-upadhyay1110 <[email protected]>
1930be4
to
e7b20af
Compare
@Darshan-upadhyay1110 When reviewing i figured out a better place to put this which actually resolves the flickering as well.
|
Summary
CC: @juliushaertl