Skip to content

Commit

Permalink
fix: Vue app names
Browse files Browse the repository at this point in the history
This improves the debugging experience in the vue dev tool.

Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
artonge committed Oct 3, 2024
1 parent 004d7da commit eb0143f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
10 changes: 5 additions & 5 deletions apps/files_reminders/src/components/SetCustomReminderModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -93,16 +93,16 @@ export default Vue.extend({
},

computed: {
fileId(): number {
return this.node.fileid
fileId(): number|undefined {
return this.node?.fileid
},

fileName(): string {
return this.node.basename
fileName(): string|undefined {
return this.node?.basename
},

name() {
return t('files_reminders', 'Set reminder for "{fileName}"', { fileName: this.fileName })
return this.fileName ? t('files_reminders', 'Set reminder for "{fileName}"', { fileName: this.fileName }) : ''
},

label(): string {
Expand Down
1 change: 1 addition & 0 deletions core/src/components/ContactsMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const setUp = () => {
if (mountPoint) {
// eslint-disable-next-line no-new
new Vue({
name: 'ContactsMenuRoot',
el: mountPoint,
render: h => h(ContactsMenu),
})
Expand Down
1 change: 1 addition & 0 deletions core/src/components/UserMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export const setUp = () => {
if (mountPoint) {
// eslint-disable-next-line no-new
new Vue({
name: 'AccountMenuRoot',
el: mountPoint,
render: h => h(AccountMenu),
})
Expand Down

0 comments on commit eb0143f

Please sign in to comment.