Consider link shares in removeShare method in SharingTab

Currently, the `removeShare` method in the `SharingTab` view, does not take into account `linkShares`. Since link shares now shares thesame detail view with other share types, it should therefore be considered hence this commit. Resolves : #40396 Signed-off-by: fenn-cs <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud · Sep 15, 2023 · ef5bb42 · ef5bb42
1 parent d32e03d
commit ef5bb42
Show file tree

Hide file tree

Showing 10 changed files with 20 additions and 13 deletions.
diff --git a/apps/files_sharing/src/views/SharingTab.vue b/apps/files_sharing/src/views/SharingTab.vue
@@ -356,9 +356,16 @@ export default {
 		 * @param {Share} share the share to remove
 		 */
 		removeShare(share) {
-			const index = this.shares.findIndex(item => item.id === share.id)
-			// eslint-disable-next-line vue/no-mutating-props
-			this.shares.splice(index, 1)
+			// Get reference for this.linkShares or this.shares
+			const shareList
+				= share.type === this.SHARE_TYPES.SHARE_TYPE_EMAIL
+					|| share.type === this.SHARE_TYPES.SHARE_TYPE_LINK
+					? this.linkShares
+					: this.shares
+			const index = shareList.findIndex(item => item.id === share.id)
+			if (index !== -1) {
+				shareList.splice(index, 1)
+			}
 		},
 		/**
 		 * Await for next tick and render after the list updated

diff --git a/dist/6898-6898.js b/dist/6898-6898.js
diff --git a/dist/8087-8087.js.LICENSE.txt → dist/6898-6898.js.LICENSE.txt b/dist/8087-8087.js.LICENSE.txt → dist/6898-6898.js.LICENSE.txt
diff --git a/dist/6898-6898.js.map b/dist/6898-6898.js.map
diff --git a/dist/8087-8087.js b/dist/8087-8087.js
diff --git a/dist/8087-8087.js.map b/dist/8087-8087.js.map
diff --git a/dist/core-common.js b/dist/core-common.js
diff --git a/dist/core-common.js.map b/dist/core-common.js.map
diff --git a/dist/files_sharing-files_sharing_tab.js b/dist/files_sharing-files_sharing_tab.js
diff --git a/dist/files_sharing-files_sharing_tab.js.map b/dist/files_sharing-files_sharing_tab.js.map