Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Refactor image handling #28279

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
+4,046 −3

Add image backend for Vips

6f7c1bb
Select commit
Loading
Failed to load commit list.
Draft

[RFC] Refactor image handling #28279

Add image backend for Vips
6f7c1bb
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Psalm failed Aug 16, 2024 in 9s

136 new alerts including 136 errors

New alerts in code changed by this pull request

  • 136 errors

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 61 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

UndefinedVariable Error

Cannot find referenced variable $resource

Check failure on line 73 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagesx expects GdImage, but bool|object|resource provided

Check failure on line 74 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

RedundantCondition Error

int can never contain false

Check failure on line 86 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagesy expects GdImage, but bool|object|resource provided

Check failure on line 87 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

RedundantCondition Error

int can never contain false

Check failure on line 124 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagegif expects GdImage, but bool|object|resource provided

Check failure on line 127 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagejpeg expects GdImage, but bool|object|resource provided

Check failure on line 130 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagepng expects GdImage, but bool|object|resource provided

Check failure on line 134 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagexbm expects GdImage, but bool|object|resource provided

Check failure on line 141 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagewbmp expects GdImage, but bool|object|resource provided

Check failure on line 144 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagebmp expects GdImage, but bool|object|resource provided

Check failure on line 148 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagepng expects GdImage, but bool|object|resource provided

Check failure on line 226 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imageflip expects GdImage, but bool|object|resource provided

Check failure on line 229 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagerotate expects GdImage, but bool|object|resource provided

Check failure on line 233 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagedestroy expects GdImage, but bool|object|resource provided

Check failure on line 380 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

TypeDoesNotContainType Error

Type GdImage|false for $this->resource is never resource

Check failure on line 381 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

NoValue Error

All possible types for this argument were invalidated - This may be dead code

Check failure on line 382 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

NoValue Error

All possible types for this argument were invalidated - This may be dead code

Check failure on line 417 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagedestroy expects GdImage, but bool|object|resource provided

Check failure on line 450 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagedestroy expects GdImage, but bool|object|resource provided

Check failure on line 458 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidReturnType Error

The declared return type 'bool|resource' for OC\Image\Gd::preciseResizeNew is incorrect, got 'GdImage|false'

Check failure on line 478 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 2 of imagecopyresampled expects GdImage, but bool|object|resource provided

Check failure on line 484 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidReturnStatement Error

The inferred type 'GdImage' does not match the declared return type 'bool|resource' for OC\Image\Gd::preciseResizeNew

Check failure on line 520 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 1 of imagedestroy cannot be false, GdImage value expected

Check failure on line 531 in lib/private/Image/Gd.php

See this annotation in the file changed.

Code scanning / Psalm

InvalidArgument Error

Argument 2 of imagecopyresampled expects GdImage, but bool|object|resource provided