Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Remove margin and width to not break layout #47600

Merged

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Aug 29, 2024

In grid view, this was messing with the reported available list width, which was breaking the computed layout.

Fix #47599

@artonge artonge requested a review from skjnldsv as a code owner August 29, 2024 09:33
Copy link
Contributor Author

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport to stable30

@artonge artonge requested a review from susnux August 29, 2024 09:33
@artonge artonge self-assigned this Aug 29, 2024
@artonge artonge added this to the Nextcloud 31 milestone Aug 29, 2024
@artonge
Copy link
Contributor Author

artonge commented Aug 29, 2024

/compile amend /

@artonge artonge enabled auto-merge August 29, 2024 11:42
@artonge artonge force-pushed the artonge/fix/files_virtual_list_grid_view_layout_computation branch from 6a984a6 to 8e9453a Compare August 29, 2024 11:42
In grid view, this was messing with the reported available list width which was breaking the computed layout.

Fix #47599

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the artonge/fix/files_virtual_list_grid_view_layout_computation branch from 8e9453a to c42f010 Compare August 29, 2024 11:50
@artonge artonge merged commit 02548bd into master Aug 29, 2024
116 checks passed
@artonge artonge deleted the artonge/fix/files_virtual_list_grid_view_layout_computation branch August 29, 2024 12:07
@artonge

This comment was marked as resolved.

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Elements moving around in Grid View when scrolling
3 participants