fix: Filter for folders in cleanup old preview job #48581
Conversation
Fixes nextcloud#35936. When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop in `run()` expects a folder, however, `getOldPreviewLocations()` currently does not filter by mimetype and therefore can yield a non-folder entry which causes an Exception when constructing the Folder impl. Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()` already does, fixes this issue. Signed-off-by: Dario Mehlich <[email protected]>
|
Same as #46072? |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
When running
OC\Preview\BackgroundCleanupJob, the main iteration loop inrun()expects a folder,however,
getOldPreviewLocations()currently does not filter by mimetypeand therefore can yield a non-folder entry which causes an Exception when constructing the Folder impl.
Filtering for
httpd/unix-directory, asgetNewPreviewLocations()already does, fixes this issue.Checklist