-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(files): add keyboard shortcuts #49432
base: master
Are you sure you want to change the base?
Conversation
75f8d4b
to
1c44235
Compare
This comment was marked as resolved.
This comment was marked as resolved.
f6eb690
to
7a278b6
Compare
Alright, first PR is ready. |
TIL, thanks :) |
Totally agree! But this is not really related to this PR. |
7a278b6
to
0eaa520
Compare
0eaa520
to
4b460ae
Compare
4b460ae
to
d33525c
Compare
prevent: true, | ||
}) | ||
|
||
useHotKey('ArrowUp', this.onKeyDown, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can use an array of expected keys here, since the're sharing the same callback:
useHotKey('ArrowUp', this.onKeyDown, { | |
useHotKey(['ArrowUp', 'ArrowDown', 'ArrowLeft', 'ArrowRight'], this.onKeyDown, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm reworking this, I should have adjusted the labels :)
I'll take that comment into consideration though, thanks! 👍
54caf2d
to
0862632
Compare
This comment was marked as resolved.
This comment was marked as resolved.
a159454
to
5223668
Compare
…rtcut Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
5223668
to
6e9de1b
Compare
Fix #1444
Fix #30484
Shortcuts
### Selection - [x] Select all - [x] Unselect all - [x] Select/unselect current fileActions
Navigation
Usability
Later
Status