Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve checks for moving shares/storages into other mounts #49552

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: improve checks for moving shares/storages into other mounts #49552

wants to merge 4 commits into from
+137 −32

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Nov 28, 2024 •
edited by Pytal
Loading

  • Also check for any mounts inside moved folders
  • Throw an exception with a meaningful message instead of returning false
  • have the webui show the message instead of a generic error

Fixes #44249

@icewind1991 icewind1991 added the 2. developing Work in progress label Nov 28, 2024
@icewind1991 icewind1991 added this to the Nextcloud 31 milestone Nov 28, 2024
Pytal
Pytal reviewed Dec 2, 2024
View reviewed changes
lib/private/Files/View.php Outdated Show resolved Hide resolved
@icewind1991 icewind1991 mentioned this pull request Dec 5, 2024
Closed
@icewind1991 icewind1991 force-pushed the mount-move-checks branch 2 times, most recently from 90ff455 to edd2e04 Compare December 13, 2024 14:34
@icewind1991
Copy link
Member Author

/compile /

@icewind1991 icewind1991 marked this pull request as ready for review December 16, 2024 15:06
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 16, 2024
@nextcloud-command
chore(assets): Recompile assets
fb7410e 
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal left review comments

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot move shared folders to external storages without parent folder
3 participants
@icewind1991 @Pytal @nextcloud-command