Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] enh: Improvements on sharing details #49631

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Dec 3, 2024

Backport of #49351

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, skjnldsv and nfebe December 3, 2024 18:16
@backportbot backportbot bot added 3. to review Waiting for reviews feature: sharing labels Dec 3, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.3 milestone Dec 3, 2024
@nfebe nfebe force-pushed the backport/49351/stable30 branch from 857dfb7 to f71aab2 Compare December 5, 2024 08:44
@nfebe nfebe marked this pull request as ready for review December 5, 2024 08:44
@nfebe
Copy link
Contributor

nfebe commented Dec 5, 2024

/backport to stable29

@nfebe
Copy link
Contributor

nfebe commented Dec 5, 2024

/compile

@blizzz blizzz mentioned this pull request Dec 5, 2024
@nfebe nfebe force-pushed the backport/49351/stable30 branch 2 times, most recently from 2da8203 to e939902 Compare December 9, 2024 02:11
@nfebe
Copy link
Contributor

nfebe commented Dec 9, 2024

/compile

This was referenced Dec 9, 2024
@skjnldsv
Copy link
Member

many failures

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 12, 2024
@nfebe nfebe force-pushed the backport/49351/stable30 branch from e939902 to 6f7e34a Compare January 2, 2025 13:43
@nfebe
Copy link
Contributor

nfebe commented Jan 2, 2025

/compile

nfebe and others added 3 commits January 2, 2025 15:28
ShareType lists both names and ids so Object.entries return too much.

This was also making useless the following condition adding ShareType.Email

Signed-off-by: Louis Chemineau <[email protected]>
@nfebe nfebe force-pushed the backport/49351/stable30 branch from bad622d to 377068e Compare January 2, 2025 14:28
@nfebe
Copy link
Contributor

nfebe commented Jan 2, 2025

/compile

Signed-off-by: nextcloud-command <[email protected]>
@nfebe nfebe merged commit ac9bc09 into stable30 Jan 2, 2025
113 checks passed
@nfebe nfebe deleted the backport/49351/stable30 branch January 2, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants