feat(conversations): add option to force passwords #13767
+333
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
the
feature: api 🛠️
DorraJaouad
reviewed
Nov 15, 2024
|
We also need 2 capabilities:
|
|
Can you rebase, so CI runs? |
miaulalala
force-pushed
the
feat/add-password-config-option
branch
from
ad9fb9f
to
25d7135
Compare
nickvergessen
requested changes
Nov 20, 2024
|
Almost there, just a small bug and some documentation fixes |
miaulalala
force-pushed
the
feat/add-password-config-option
branch
from
f7e9726
to
4a5795f
Compare
miaulalala
force-pushed
the
feat/add-password-config-option
branch
2 times, most recently
from
cf54d5d
to
010bb92
Compare
miaulalala
changed the title
…tions Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
feat/add-password-config-option
branch
from
010bb92
to
3fd8877
Compare
| @@ -115,7 +115,6 @@ | |||
| ## Creating a new conversation | |||
|
|
|||
| *Note:* Creating a conversation as a child breakout room, will automatically set the lobby when breakout rooms are not started and will always overwrite the room type with the parent room type. Also, moderators of the parent conversation will be automatically added as moderators. | |||
|
|
|||
There was a problem hiding this comment.
this needs to be readded (otherwise the docs list breaks), try to run mkdocs serve locally
There was a problem hiding this comment.
$password parameter should also be added to Allow guests in a conversation (public conversation)
| @@ -645,10 +654,10 @@ protected function createCircleRoom(string $targetCircleId): DataResponse { | |||
| } | |||
|
|
|||
| /** | |||
| * @return DataResponse<Http::STATUS_CREATED, TalkRoom, array{}>|DataResponse<Http::STATUS_BAD_REQUEST, array{error?: string}, array{}>|DataResponse<Http::STATUS_NOT_FOUND, array<empty>, array{}> | |||
| * @return DataResponse<Http::STATUS_CREATED, TalkRoom, array{}>|DataResponse<Http::STATUS_BAD_REQUEST, array{error?: string, hint?: string}, array{}>|DataResponse<Http::STATUS_NOT_FOUND, array<empty>, array{}> | |||
There was a problem hiding this comment.
Should we use message to align with the other cases where we add the human readable message?
Suggested change
| * @return DataResponse<Http::STATUS_CREATED, TalkRoom, array{}>|DataResponse<Http::STATUS_BAD_REQUEST, array{error?: string, hint?: string}, array{}>|DataResponse<Http::STATUS_NOT_FOUND, array<empty>, array{}> | |
| * @return DataResponse<Http::STATUS_CREATED, TalkRoom, array{}>|DataResponse<Http::STATUS_BAD_REQUEST, array{error?: string, message?: string}, array{}>|DataResponse<Http::STATUS_NOT_FOUND, array<empty>, array{}> |
Same then in the actual code I guess
| } catch (TypeException $e) { | ||
| return new DataResponse(['error' => $e->getReason()], Http::STATUS_BAD_REQUEST); | ||
| } | ||
|
|
||
| return new DataResponse(); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
in public conversations
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required