feat(invitations): Import e-mail participants from CSV 🗒️ #13875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
enhancement
feature: frontend 🖌️
Antreesy
changed the title
| <NcButton type="primary" | ||
| :disabled="!uploadResult" | ||
| @click="submitList(importedFile)"> | ||
| {{ t('spreed', 'Submit list from file') }} |
There was a problem hiding this comment.
The label feels wrong.
Does it to "testRun" on upload automatically now?
Or should it be a dedicated button?
There was a problem hiding this comment.
yes, testRun is going automatically when upload a file
There was a problem hiding this comment.
I would still call it "Send invites" or something?
cc @DorraJaouad what do you think, as Maksim is on vacation
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feat/13451/import-email-list
branch
from
8bd5be8
to
ee1aaa3
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feat/13451/import-emails-frontend
branch
from
57de980
to
1e7c6ca
Compare
|
|
||
| try { | ||
| await importEmails(props.token, file, false) | ||
| showSuccess(t('spreed', 'Participants added successfully')) |
There was a problem hiding this comment.
this should also close the dialog
nickvergessen
force-pushed
the
feat/13451/import-email-list
branch
from
ee1aaa3
to
6017b86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist