docs-ci: Don't error on timeouts #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
victorlin
force-pushed
the
victorlin/docs-ci-linkcheck
branch
2 times, most recently
from
94a72a3 to
433734d
Compare
linkcheck errors on both timeouts and broken links.¹ We only want the CI job to fail on broken links since timeouts are most likely transient. ¹ https://github.com/sphinx-doc/sphinx/blob/2f1d775dfda9e4f81dfff6cfbe9edf7731e32a97/sphinx/builders/linkcheck.py#L82-L83
victorlin
force-pushed
the
victorlin/docs-ci-linkcheck
branch
from
913cb8c to
4955782
Compare
genehack
approved these changes
Oct 16, 2024
victorlin
force-pushed
the
victorlin/docs-ci-linkcheck
branch
from
12d5ab4 to
4955782
Compare
This was referenced Oct 16, 2024
|
I was ambiently aware some sort of improvement was happening here but wasn't paying much attention. Just a bit ago though I saw the results of this PR in another PR's failure and it was so much better than previously. Thank you! |
|
Awesome, glad to hear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
linkcheck errors on both timeouts and broken links. We only want the CI job to fail on broken links since timeouts are most likely transient.
Related issue(s)
make linkcheckprone to transient network failures #106Checklist