Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run nextstrain update on conda runtime only #60

Closed
wants to merge 2 commits into from

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Sep 25, 2023

Description of proposed changes

This was added as a workaround for the conda runtime only, though that reasoning is not clear without digging into commit messages and GitHub comments.

This makes that more clear, and also removes the need to continue-on-error for runtimes unsupported by nextstrain update.

Related issue(s)

Prompted by #49 (comment)

Checklist

@victorlin victorlin self-assigned this Sep 25, 2023
@victorlin victorlin marked this pull request as draft September 25, 2023 21:20
This was added as a workaround for the conda runtime only, though that
reasoning is not clear without digging into commit messages and GitHub
comments.

This makes that more clear, and also removes the need to
continue-on-error for runtimes unsupported by nextstrain update.
@victorlin victorlin force-pushed the victorlin/conditional-nextstrain-update branch from e3a6aa4 to 4366771 Compare September 25, 2023 21:21
@victorlin victorlin marked this pull request as ready for review September 25, 2023 21:30
@victorlin
Copy link
Member Author

Closing in favor of #61.

@victorlin victorlin closed this Sep 25, 2023
@victorlin victorlin deleted the victorlin/conditional-nextstrain-update branch September 25, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant