pathogen-repo-build: always generate AWS Batch Job ID & summary #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into a workflow run where the `run-build` step failed and the job exited without generating the AWS Batch Job ID or summary.¹ This commit updates the condition to always try to generate the AWS Batch ID as long as the runtime is `aws-batch` and the `build.log` file exists. This then allows the workflow to always generate the AWS Batch Job summary even if the build failed. ¹ https://github.com/nextstrain/forecasts-ncov/actions/runs/8203385071
Makes it easier to debug what the value of the `AWS_BATCH_JOB_ID` variable is being set to if it's output to stdout and visible in the GitHub Action logs.
|
OH right, 6f69e71 wouldn't work because the setup-nextstrain-cli action now uses the standalone installation. |
joverlee521
force-pushed
the
pathogen-repo-build-summary
branch
from
6f69e71 to
23b3b53
Compare
tsibley
reviewed
Apr 18, 2024
| - if: ${{ inputs.runtime == 'aws-batch' }} | ||
| # Attempt to get the AWS Batch ID even if the run build command failed | ||
| # as long as the runtime is `aws-batch` and the `build.log` file exists | ||
| - if: ${{ always() && inputs.runtime == 'aws-batch' && hashFiles('build.log') != '' }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Ran into a workflow run where the
run-buildstep failed and the job exited without generating the AWS Batch Job ID or summary.¹This commit updates the condition to always try to generate the AWS Batch ID as long as the runtime is
aws-batchand thebuild.logfile exists. This then allows the workflow to always generate the AWS Batch Job summary even if the build failed.¹ https://github.com/nextstrain/forecasts-ncov/actions/runs/8203385071
Related issue(s)
Checklist