pathogen-repo-build: Move build.log to ignored directory
#78
Conversation
The entire working directory gets zipped and uploaded to AWS Batch when using the `aws-batch` runtime, which includes an early `build.log` file. When the build completes and downloads the build outputs, the early `build.log` overwrites the local `build.log` of the GH Action. This results in a truncated file that does not include the AWS_BATCH_JOB_ID and prevents the generation of the AWS Batch summary and the re-attachment to the AWS Batch job in subsequent `wait` jobs. This commit moves the hard-coded `build.log` file to an ignored directory (the same directory that we are using for the nextstrain/.github repo¹). This prevents the `build.log` from being uploaded with the build. Previously tried other paths, but they all caused errors. - "../build.log" - ".." pattern is not allowed for the `upload-artifact` action² - "~/build.log" - `hashfiles` requires files to be in the `GITHUB_WORKSPACE`³ ¹ #44 (comment) ² actions/upload-artifact#176 ³ https://docs.github.com/en/actions/learn-github-actions/expressions#hashfiles
|
The CI workflow included the AWS Batch job summary 🎉 The CI workflow now reveals a separate issue...In the CI workflow, the aws-batch build is run without the I don't think it's worth complicating the workflow logic just to prevent an extra |
Taking @victorlin's suggestion¹ to keep the `.git/build.log` as an implementation detail within the workflow. ¹ #78 (comment)
|
Merging since I intend to do some additional work on the pathogen-repo-build workflow to support role assumption in other runtimes. |
Description of proposed changes
See commit for details.
Related issue(s)
Resolves #77
Checklist