Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUGUR_DEBUG documentation #1587

Merged
merged 3 commits into from
Aug 20, 2024
Merged

AUGUR_DEBUG documentation #1587

merged 3 commits into from
Aug 20, 2024

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Aug 20, 2024

See commit messages.

Related to #1577.

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

Among other things, this makes the var names linkable with

    :envvar:`…`

and indexes them not just individually but also collectively under
"Environment variables" so the index includes a single list of all
documented vars.

When I originally wrote this page, I didn't yet know about the envvar
directive and role.  I've since used it extensively in Nextstrain CLI's
documentation, though.
…instead of being buried in the developer API pages.  Much more
discoverable.

Modifies formatting of the rST to match the new document's existing
formatting, but the content is the same.

Thanks to @joverlee521 for catching this misplacement in post-merge
review.¹

¹ <#1577 (comment)>
Includes clarification of "a truthy value" as "a non-empty value", since
all env vars values are strings and any non-empty string is a truthy
value in Python.  The new phrasing matches existing phrasing in our docs
and makes it much clearer to a reader not thinking about details of
Python's values.
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know about the envvar directive!

@tsibley tsibley merged commit d8faf01 into master Aug 20, 2024
28 checks passed
@tsibley tsibley deleted the trs/document-AUGUR_DEBUG branch August 20, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants