Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextstrain-automation build-configs to phylogenetic worklfow #37

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

j23414
Copy link
Contributor

@j23414 j23414 commented Mar 27, 2024

Description of proposed changes

Adds a custom config and rules for deploying the final Auspice dataset of the phylogenetic workflow.

From slack, had permission to duplicate changes from nextstrain/zika#51

Related issue(s)

Checklist

  • Checks pass

j23414 added 2 commits March 27, 2024 08:39
Add config and rules for Nextstrain automation to deploy the Dengue
dataset

Copied commit from zika: nextstrain/zika@810e1d2
As duplicating nextstrain/zika#51
@j23414 j23414 requested review from joverlee521 and a team March 27, 2024 08:54
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up here, changes look good by inspection!

@j23414 j23414 merged commit 2b9f8d6 into main Apr 2, 2024
32 checks passed
@j23414 j23414 deleted the phylo-deploy branch April 2, 2024 22:12
@@ -0,0 +1,15 @@
"""
This part of the workflow handles automatic deployments of the zika build.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This part of the workflow handles automatic deployments of the zika build.
This part of the workflow handles automatic deployments of the dengue build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victorlin @joverlee521 , could we generalize this and just say "pathogen" build?

This way there's less to trip-over when applying these rules to other pathogens of interest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, submitted as a hotfix: b2c3655

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, +1 for less pathogen-specific stuff.

j23414 added a commit that referenced this pull request Apr 4, 2024
Pointed out post merge by commit suggestion in PR #37:

#37 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants