-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IQtree version with cmaple feature #226
Comments
As I've mentioned in our Nextstrain zoom call: docker-base is what's holding us back from using iqtree's cmaple mode in workflows with CI. Cmaple mode means we get: a) better trees, b) faster, c) don't need to run a somewhat buggy fix-tree script. Pinging a few who could be interested/helping here: @huddlej @victorlin @tsibley |
We want the CMAPLE support (first available with 2.3.4) for better and faster trees. CMAPLE support is optional and not all release builds of IQ-TREE have it enabled. So far, it seems that the "main" releases are made without CMAPLE support (e.g. 2.3.5) and then parallel releases are made with it (e.g. 2.3.5.cmaple), but only for x86_64 on Linux and macOS. Thus, we're still not using an aarch64/arm64 binary even though the "main" releases (without CMAPLE support) provide them. If we keep waiting, maybe they'll start being provided, or, eventually, we can start compiling them ourselves. That's for another time, though. Resolves: <#226>
The change required here seems trivial? Trying it out in #228. (Separately, |
#228 seems ok to me. |
Context
I've enabled the cmaple feature in bioconda's iqtree build.
Now what's stopping us from using it in nextstrain builds that are run in ci is lack of that feature in docker-base iqtree.
Binaries are available here: https://github.com/iqtree/iqtree2/releases/tag/v2.3.5.cmaple
Or one could just repackage the bioconda binaries directly - which would have the advantage of
linux-aarch64
being available as well. This would solve #212The text was updated successfully, but these errors were encountered: