Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared table of contents across all nextstrain read the docs projects #27

Open
eharkins opened this issue Oct 15, 2020 · 9 comments
Open
Assignees

Comments

@eharkins
Copy link
Contributor

We achieve #3 using git submodules; see https://github.com/nextstrain/docs.nextstrain.org/tree/migrate#submodules

However, this solution is not ideal; see https://bedfordlab.slack.com/archives/C7SDVPBLZ/p1602020878007600

So, we also use Read The Docs subprojects; see https://github.com/nextstrain/docs.nextstrain.org/tree/migrate#how-we-are-currently-using-subprojects

This issue is a placeholder for a "best of both worlds" approach, which is currently being pursued by @trs:

A subprojects + shared/global table of contents approach is preferred to the current subprojects + submodules + separate table of contents approach.
I'll carve a few days out to finish implementing this, and at the same time, James and Eli will continue to push forward with their remaining tasks. We'll see how timing of the completion of both coincides and make a decision to either launch docs.nextstrain.org with the current approach or use the new approach depending on if the new approach is ready.
If the launch happens with the current approach, then we can switch approaches later, just with a bit more tedium.

For more discussion on that, see https://bedfordlab.slack.com/archives/C7SDVPBLZ/p1602626783056100?thread_ts=1602622975.053700&cid=C7SDVPBLZ

@eharkins
Copy link
Contributor Author

In #36 we move from a submodule approach to a fetching approach where we make a request for a page from it's github URL. Importantly we still hope to replace that approach with the approach mentioned here: a shared table of contents across nextstrain read the docs projects.

@tsibley
Copy link
Member

tsibley commented Jul 13, 2023

@tsibley
Copy link
Member

tsibley commented Jul 13, 2023

and also for posterity, my original investigation for this (~2.5yrs ago) primarily resulted in some Sphinx code diving and discussion in sphinx-doc/sphinx#1836.

@victorlin
Copy link
Member

I'm out of the loop here and have a couple questions:

  1. Given that all the projects have pretty different TOCs, what would a shared TOC look like?
  2. Is this the only solution to stop fetching docs from other repositories?

@tsibley
Copy link
Member

tsibley commented Apr 24, 2024

The original idea was that you could browse/read the subprojects without losing access to the umbrella project's sidebar/search. For example, if you click on "Nextstrain CLI" from the umbrella project:

image

You end up with a wholly different sidebar. This can be a bit disorienting. To switch to the Augur docs, for example, you have to go back to (resurface in) the umbrella project and then dive back down again. Disorientation can also crop up via search. If you search in the umbrella project, you get search across all projects. That's a good thing! But if you click into a result for Augur, you're then siloed there until you pop back up to the umbrella project.

@tsibley
Copy link
Member

tsibley commented Apr 24, 2024

A shared TOC could look like "Nextstrain CLI" and those other components above being headings with pages beneath them, like other bits of the umbrella project.

It's not the only solution to not fetching docs across repos. But regardless of whether we fetch or not, a shared TOC would make for a less disorienting/fractured experience.

@victorlin
Copy link
Member

+1 for a solution here which I'm assuming will also solve the cross-searching problem. I just took a look at the Nextstrain CLI docs search analytics and these are the top queries from the past 30 days:

image

Lots of "0 results" which could benefit from the ability to search across projects.

@tsibley
Copy link
Member

tsibley commented Sep 16, 2024

Lots of "0 results" which could benefit from the ability to search across projects.

We have cross-project search on the umbrella project, but the project-scoped sidebar is again tripping us up here.

@victorlin
Copy link
Member

Yes, I should have said "ability to search across projects from any docs page".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants