Fetch docs instead of using submodules #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this calls fetch-docs from src/conf.py instead of the Makefile so that it will hopefully work on the build on readthedocs.org
using python so we can have source and destinations for each fetched doc in a dict
this messes with the titles of documents as rtd reads them, and it makes more sense to add these files to gitignore
|
Note that this also involves some changes to other repositories where the relevant documents are hosted; see:
|
|
Looks like we will need to update some redirect url entries in https://github.com/nextstrain/nextstrain.org/pull/226/files. I'll wait to do so until we confirm they are what we want here. |
This was referenced Nov 10, 2020
jameshadfield
approved these changes
Nov 11, 2020
eharkins
added a commit
to nextstrain/augur
that referenced
this pull request
Nov 11, 2020
Update links according to URLs resulting from the merging of nextstrain/docs.nextstrain.org#36
eharkins
added a commit
to nextstrain/nextstrain.org
that referenced
this pull request
Nov 11, 2020
Update links according to URLs resulting from the merging of nextstrain/docs.nextstrain.org#36
jameshadfield
pushed a commit
to nextstrain/augur
that referenced
this pull request
Nov 12, 2020
Update links according to URLs resulting from the merging of nextstrain/docs.nextstrain.org#36
This was referenced Nov 12, 2020
eharkins
added a commit
that referenced
this pull request
Nov 13, 2020
This was referenced Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
As discussed on Slack, we now fetch documents that live in other repos instead of using submodules (at least until #27 happens).
Related issue(s)
#3 #14
Testing
Build works locally and on rtd, and I addressed all warnings related to relative links etc.
Still would be good to have another pair(s) of eyes to check for broken links etc, and ask the important questions about how this sets us up for success or failure when it comes to #27.
Thank you for contributing to Nextstrain!