Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioned resources copyedits #178

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Jan 17, 2024

See commit messages for details.

Related to #177.

Checklist

  • Checks pass

This "Viewing previous versions" guide seems worth being more prominent
than managing an installation or contributing guides.

I also think this is more of an explanatory document than how-to guide,
which suggests it belongs under our "About" section instead, but I'll
discuss that with the team first.
@tsibley tsibley requested review from jameshadfield and a team January 17, 2024 01:07
@tsibley
Copy link
Member Author

tsibley commented Jan 17, 2024

@jameshadfield Just a few small edits for consistency which I think are improvements. Overall the document you wrote is a great compact and punchy guide-by-example of the dated snapshots feature!

@tsibley
Copy link
Member Author

tsibley commented Jan 17, 2024

Ah, I'll fix that CI warning tomorrow.

Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice to have someone else's eyes on these things.

First three commits seem good to me.

I'm ambivalent about "snapshot" (yes I realise I used it in the overview paragraph) so it'd be good to get some other opinions from the team about what language is best used here. In the (internal facing) code I use "version" and don't want to change that.

The document already used the term "snapshot" a bit, and I think it's
less ambiguous/overloaded than "version" so use it consistently.
"Analyses" is already in use in other document and section titles, so
use that term in those contexts.

I didn't update the source document file names here, but maybe I should…
@tsibley tsibley force-pushed the trs/versioned-resources-copyedits branch from 7a470d6 to 528c9a3 Compare January 17, 2024 17:51
@tsibley
Copy link
Member Author

tsibley commented Jan 17, 2024

I'm ambivalent about "snapshot" (yes I realise I used it in the overview paragraph) so it'd be good to get some other opinions from the team about what language is best used here. In the (internal facing) code I use "version" and don't want to change that.

Nod. Your usage of "snapshot" there is what made me think about the terminology here for user-facing docs. I think "snapshots" will be clearer than "versions" for typical users and not muddied with the unrelated topic of software versions. Definitely fine to keep using "version" internally.

@tsibley tsibley requested a review from a team January 17, 2024 17:59
@tsibley
Copy link
Member Author

tsibley commented Jan 17, 2024

First three commits seem good to me.

I've merged those (merge commit be6d3f5). Will wait for the remaining two.

@tsibley tsibley merged commit 9adcff6 into master Jan 18, 2024
4 checks passed
@tsibley tsibley deleted the trs/versioned-resources-copyedits branch January 18, 2024 19:10
@tsibley
Copy link
Member Author

tsibley commented Jan 18, 2024

Conclusion at the biweekly all-hands discussion just now was "snapshot", so I've merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants