Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-formats: Add example Python snippets for TSV handling #239

Merged
merged 2 commits into from
Dec 5, 2024
Merged

data-formats: Add example Python snippets for TSV handling #239

merged 2 commits into from
Dec 5, 2024

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Dec 4, 2024 •
edited
Loading

docs preview

Prompted by @jameshadfield's request
#238 (comment)

Snippets are simplified versions of TSV handling in Augur.

Related issue(s)

Follow up to #238

Checklist

  • Checks pass

@joverlee521
Copy link
Contributor Author

Sigh, another 403 Client error, this time from linkcheck

Broken links found:
{
  "filename": "reference/ca-certificates.rst",
  "lineno": 92,
  "status": "broken",
  "code": 0,
  "uri": "https://wiki.mozilla.org/CA/Included_Certificates",
  "info": "403 Client Error: Forbidden for url: https://wiki.mozilla.org/CA/Included_Certificates"
}

jameshadfield
jameshadfield approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

victorlin
victorlin approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@victorlin victorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 pending one small thing

src/reference/data-formats.rst Outdated Show resolved Hide resolved
@victorlin
Copy link
Member

For the linkcheck 403, since it's happening consistently, we should stop checking that link (example).

@joverlee521
Copy link
Contributor Author

For the linkcheck 403, since it's happening consistently, we should stop checking that link (example).

Thanks for the example! I do want to note that the link check succeeds when I run it locally...but I will not dwell on it and add it to the ignored list.

genehack
genehack approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@genehack genehack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple non-blocking nits about the writing, but LGTM

src/reference/data-formats.rst Outdated Show resolved Hide resolved
src/reference/data-formats.rst Outdated Show resolved Hide resolved
@joverlee521
data-formats: Add example Python snippets for TSV handling
95b4ae8 
Prompted by @jameshadfield's request
<#238 (comment)>

Snippets are simplified versions of TSV handling in Augur.
@joverlee521
Ignore CA Certificate link for linkcheck
13bac65 
This has consistently returned 403 in GitHub Actions workflow, but
does succeed when running linkcheck locally. Ignoring link for now and
we can revisit later.
@joverlee521 joverlee521 merged commit 9ad0b78 into master Dec 5, 2024
3 checks passed
@joverlee521 joverlee521 deleted the tsv-handling branch December 5, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorlin victorlin victorlin approved these changes

@jameshadfield jameshadfield jameshadfield approved these changes

@genehack genehack genehack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joverlee521 @victorlin @genehack @jameshadfield