Add shellcheck to precommit

nextstrain · Sep 24, 2023 · 700d6b6 · 700d6b6
1 parent d64596c
commit 700d6b6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -32,8 +32,12 @@ repos:
     hooks:
       - id: sync-pre-commit-deps
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.2.4
+    rev: v2.2.5
     hooks:
-    - id: codespell
-      additional_dependencies:
-        - tomli
+      - id: codespell
+        additional_dependencies:
+          - tomli
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.9.0.5
+    hooks:
+      - id: shellcheck
diff --git a/bin/notify-on-start b/bin/notify-on-start
@@ -15,7 +15,7 @@ slack_ts_output="${2:?A Slack thread timestamp file is required as the second ar
 
 slack_response="$(mktemp -t slack-response-XXXXXX)"
 
-trap "rm -f '$slack_response'" EXIT
+trap 'rm -f "$slack_response"' EXIT
 
 echo "Notifying Slack about starting build."
 message="Pipeline starting for the \`$build_name\` build, which will run the phylogenetics and deploy the build."