-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
annotate mutations between the inferred root and the reference sequence #296
Comments
I can add the config option to make this togglable in the workflow. However, it's not clear to me if we need to be using this option for Nextstrain builds to support Nextclade use when the official Nextclade datasets already exist. I just checked and the core all-clades build errors out on Nextclade and the core clade-IIb build shows the extra mutations |
Hello! While I'm trying to maintain a WA-focused mpox build, I was wondering if you had an ETA for when this feature would be available? I don't think we need to rush; I'm just trying to figure out the best way to be able to keep the changes we made to the snakefile while also being able to pull new changes in order to maintain the build while we wait for this feature to become available |
Hey @DOH-SML1303, I've made the changes in #297. I'll wait for feedback and will most likely merge it later next week. |
Sounds good, thank you so much! |
Hi @DOH-SML1303, the PR has been merged! If you pull down the latest Here is an example in the CI workflow config: mpox/phylogenetic/build-configs/ci/config.yaml Lines 4 to 5 in 02f660a
|
Hi @joverlee521, amazing! Thank you so much. I will pull this down and run the build this week and let you know if I have any problems. I appreciate you all working on this! |
Feature request via WA-DoH (via slack): annotating mutations between the inferred root and the reference sequence is necessary for datasets to be used within Nextclade. Without this the masking leads to a the inferred root sequence having large runs of
A
s which lead to incorrect mutations called against new sequences within Nextclade.Adding a config flag which allows workflows to toggle this on/off is a solution.
Here's a diff of the changes (without the ability for a config to modulate this):
The text was updated successfully, but these errors were encountered: