Move phylogenetic workflow to folder #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
reviewed
Sep 22, 2023
There was a problem hiding this comment.
phylogenetics or phylogenetic?
I'm assuming this will mirror @joverlee521's pathogen-repo-template, which currently uses phylogenetic.
There was a problem hiding this comment.
phylogenetic is an adjective which is just hanging there, begging for a noun whereas phylogenetics can stand for free. I don't know what the reasoning was to choose phylogenetic for the template. I guess my proposal would be to change it in the template.
|
This is a draft, I'll redo it with a force-push as there've been changes to README etc that would be annoying to resolve as merge conflicts. |
|
Close in favor of #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this repo will contain 3 separate workflows soon (ingest, nextstrain builds, nextclade datasets) it makes sense to move the nextstrain build workflow to its own folder so that the top level is nice and clean.