Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit to CI lint action #195

Closed
wants to merge 1 commit into from
Closed

Conversation

corneliusroemer
Copy link
Member

@corneliusroemer corneliusroemer commented Sep 23, 2023

CI errors with

[Error: .github#L1](https://github.com/nextstrain/monkeypox/commit/8d0c898f30d9e6f99ae682edb5b544763af2bbbd#annotation_14383331521)
pre-commit/[email protected] is not allowed to be used in nextstrain/monkeypox. Actions in this workflow must be: within a repository owned by nextstrain, created by GitHub, or matching the following: aws-actions/configure-aws-credentials@*, codecov/codecov-action@*, conda-incubator/setup-miniconda@*, docker/build-push-action@*, docker/login-action@*, docker/setup-buildx-action@*, mamba-org/provision-with-micromamba@*, peter-evans/create-pull-request@v3, stefanzweifel/git-auto-commit-action@v4, docker/setup-qemu-action@*, dependabot/fetch-metadata@*, mamba-org/setup-micromamba@*, ruby/setup-ruby@v1.

Do you think it's worth adding precommit to the list of approved actions @victorlin?

@corneliusroemer corneliusroemer marked this pull request as draft September 23, 2023 23:06
@corneliusroemer
Copy link
Member Author

corneliusroemer commented Sep 24, 2023

Scrap that, pre-commit.ci is much better, the action is deprecated anyways

Amazing how fast that ci is:
https://results.pre-commit.ci/run/github/493877605/1695563576.CIqEySbARgqv9iZywkGRAA

Using it in #200

@corneliusroemer corneliusroemer deleted the pre-commit-action branch September 24, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant