Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch CI to pathogen-repo-ci action [#257] #258

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Switch CI to pathogen-repo-ci action [#257] #258

merged 1 commit into from
Jun 13, 2024

Conversation

genehack
Copy link
Contributor

@genehack genehack commented Jun 11, 2024 •
edited
Loading

Description of proposed changes

Switch CI GitHub Action to use pathogen-repo-ci

Related issue(s)

Checklist

  • Checks pass

@genehack genehack requested review from joverlee521, tsibley, corneliusroemer and a team June 11, 2024 23:18
joverlee521
joverlee521 reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automated change in 515bb0c is annoying, I think it's helpful to keep the comments in nextstrain-pathogen.yaml...Is this a configuration we can update in the .yamlfmt?

@joverlee521 joverlee521 mentioned this pull request Jun 12, 2024
Closed
4 tasks
@genehack
Switch CI to pathogen-repo-ci action [#257]
967c80d 
Also add `nextstrain-pathogen.yaml` so that the new workflow triggers.
@genehack
Copy link
Contributor Author

The automated change in 515bb0c is annoying, I think it's helpful to keep the comments in nextstrain-pathogen.yaml...Is this a configuration we can update in the .yamlfmt?

  1. agree that it is annoying
  2. found this issue that suggests a fix

However, that fix will have the side-effect of injecting a --- as the first line of ...every other YAML file in the repo. >_<

I have opted instead to exclude the nextstrain-pathogen.yaml file in the .yamlfmt config.

@joverlee521
Copy link
Contributor

However, that fix will have the side-effect of injecting a --- as the first line of ...every other YAML file in the repo. >_<

That's unfortunate...agree with just excluding the nextstrain-pathogen.yaml file in the .yamlfmt config 👍

@genehack genehack merged commit 3315ff1 into master Jun 13, 2024
5 checks passed
@genehack genehack deleted the update-ci-257 branch June 13, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joverlee521 joverlee521 joverlee521 approved these changes

@tsibley tsibley Awaiting requested review from tsibley

@corneliusroemer corneliusroemer Awaiting requested review from corneliusroemer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genehack @joverlee521