Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize repo #2

Closed
30 tasks done
genehack opened this issue May 23, 2024 · 0 comments · Fixed by #20
Closed
30 tasks done

Modernize repo #2

genehack opened this issue May 23, 2024 · 0 comments · Fixed by #20
Assignees
Labels
enhancement New feature or request

Comments

@genehack
Copy link
Contributor

genehack commented May 23, 2024

Rough plan of attack:

@genehack genehack added enhancement New feature or request source: office hours Issue mentioned during office hours labels May 23, 2024
@genehack genehack self-assigned this May 23, 2024
@genehack genehack removed the source: office hours Issue mentioned during office hours label May 23, 2024
genehack added a commit that referenced this issue May 23, 2024
Once the repo modernization is complete, these files will be deleted;
for the moment this allows them to be easily accessed.
genehack added a commit that referenced this issue May 23, 2024
Exclude the _LEGACY tree because there's no point in cleaning that
stuff up; leave a comment so I remember to go back and remove it when
`_LEGACY` goes away.
genehack added a commit that referenced this issue May 23, 2024
genehack added a commit that referenced this issue May 29, 2024
Remove unused configuration files
This was referenced May 30, 2024
genehack added a commit that referenced this issue Jun 27, 2024
* sync `ingest/README` with `seasonal-cov` version
* move from `defaults` to `config` for config files
* strip fetch-from-entrez stuff from config and rules files
* add `ncbi_taxon_id` to config
* strip guidance comments, light reformat of Snakemake and rules files
  for readability
* add benchmarks where missing
* remove unused nextclade bits
genehack added a commit that referenced this issue Jul 11, 2024
* sync `ingest/README` with `seasonal-cov` version
* move from `defaults` to `config` for config files
* strip fetch-from-entrez stuff from config and rules files
* add `ncbi_taxon_id` to config
* strip guidance comments, light reformat of Snakemake and rules files
  for readability
* add benchmarks where missing
* remove unused nextclade bits
* add "clean" convenience rule
genehack added a commit that referenced this issue Jul 18, 2024
* Update template files to remove instructions and placeholders
* Add Genbank and GFF references
* Bring in phylo workflow from pathogen-repo-guide and modify to work
genehack added a commit that referenced this issue Jul 18, 2024
Also remove exclusion from .pre-commit-config.yaml
genehack added a commit that referenced this issue Jul 18, 2024
* Drop to Python 3.11 in GitHub pre-commit CI, to match actual
  development practice
* Clean up formatting of several files
* Convert all Markdown links to use reference dictionary at end of
  file
* Add `log` and `benchmark` to all Snakemake rules that didn't have
  them
* Remove `dump_ncbi_dataset_report` rule
genehack added a commit that referenced this issue Jul 18, 2024
genehack added a commit that referenced this issue Jul 19, 2024
* Update template files to remove instructions and placeholders
* Add Genbank and GFF references
* Bring in phylo workflow from pathogen-repo-guide and modify to work
genehack added a commit that referenced this issue Jul 19, 2024
Also remove exclusion from .pre-commit-config.yaml
genehack added a commit that referenced this issue Jul 19, 2024
* Drop to Python 3.11 in GitHub pre-commit CI, to match actual
  development practice
* Clean up formatting of several files
* Convert all Markdown links to use reference dictionary at end of
  file
* Add `log` and `benchmark` to all Snakemake rules that didn't have
  them
* Remove `dump_ncbi_dataset_report` rule
genehack added a commit that referenced this issue Jul 19, 2024
genehack added a commit that referenced this issue Jul 19, 2024
* Update template files to remove instructions and placeholders
* Add Genbank and GFF references
* Bring in phylo workflow from pathogen-repo-guide and modify to work
genehack added a commit that referenced this issue Jul 19, 2024
Also remove exclusion from .pre-commit-config.yaml
genehack added a commit that referenced this issue Jul 19, 2024
* Drop to Python 3.11 in GitHub pre-commit CI, to match actual
  development practice
* Clean up formatting of several files
* Convert all Markdown links to use reference dictionary at end of
  file
* Add `log` and `benchmark` to all Snakemake rules that didn't have
  them
* Remove `dump_ncbi_dataset_report` rule
genehack added a commit that referenced this issue Nov 16, 2024
...instead of depending on having one built locally.

Also corrects nextclade dataset name in the config.
genehack added a commit that referenced this issue Nov 21, 2024
genehack added a commit that referenced this issue Nov 21, 2024
This makes the metadata annotations in the Auspice visualization look
much nicer.
genehack added a commit that referenced this issue Nov 21, 2024
This is _largely_ copy-pasta-ed from the `measles` repo; the one
significant change is I enabled the frequencies on both the whole
genome and prM-E builds, and I set the `min_date` param to
`2017-01-01`, because virtually all of the post-1927 samples are dated
2017 and later.
genehack added a commit that referenced this issue Nov 21, 2024
Also small script tweak
genehack added a commit that referenced this issue Nov 21, 2024
genehack added a commit that referenced this issue Nov 21, 2024
This is the full NCBI yellow-fever dataset (taxon ID 11089) as
downloaded on 21 Nov 2024.

CI _could_ work just fine without embedding this data in the repo, but
having a hard-coded example-data file means that we don't depend on
NCBI for successful CI runs.
genehack added a commit that referenced this issue Nov 21, 2024
@genehack genehack mentioned this issue Nov 21, 2024
1 task
genehack added a commit that referenced this issue Nov 21, 2024
genehack added a commit that referenced this issue Nov 26, 2024
Also small script tweak
genehack added a commit that referenced this issue Nov 26, 2024
Also add custom rule import bits to phylogenetic/Snakefile
genehack added a commit that referenced this issue Nov 26, 2024
This is the full NCBI yellow-fever dataset (taxon ID 11089) as
downloaded on 21 Nov 2024, and the ingested sequences and metadata as
downloaded from Nextstrain on 21 Nov 2024.

CI _could_ work just fine without embedding this data in the repo, but
having a hard-coded example-data file means that we don't depend on
NCBI or Nextstrain.org for successful CI runs.
genehack added a commit that referenced this issue Nov 26, 2024
genehack added a commit that referenced this issue Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant