Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relabel clades numerically, rather than geographically [#12] #13

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

genehack
Copy link
Contributor

Also update nextclade build README to give mapping back to literature genotypes.

Closes #12

Also update nextclade build README to give mapping back to literature
genotypes.
@genehack genehack requested review from joverlee521 and trvrb August 20, 2024 23:48
Copy link

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable with a quick look at the updated Nextclade dataset. I left some non-blocking questions, but LGTM.

nextclade/README.md Show resolved Hide resolved
clade_membership Clade IV #A6BE55
clade_membership Clade V #DC2F24
clade_membership Clade VI #E68133
clade_membership Clade VII #D4B13F

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember if we discussed in the meeting whether we want multiple clade systems in the Nextclade dataset, i.e. should we have these numeric clades as the default, but still include the geographical genotype labels as a separate color-by?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember if we discussed in the meeting whether we want multiple clade systems in the Nextclade dataset, i.e. should we have these numeric clades as the default, but still include the geographical genotype labels as a separate color-by?

The impression that I took away from the feedback in that meeting was that we wanted to de-emphasize the geographically oriented names, so I would lean away from allowing color-by for them.

@genehack genehack merged commit 1bf51d9 into main Aug 22, 2024
1 check passed
@genehack genehack deleted the relabel-clades-12 branch August 22, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-label clades as 1/2/3 instead of geographically-based names
2 participants