Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename phylogenetic CI config file to standard name #63

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

genehack
Copy link
Contributor

@genehack genehack commented Jun 5, 2024

No description provided.

@genehack genehack requested a review from a team June 5, 2024 17:49
@genehack genehack force-pushed the standardize-config-name branch from 09871ba to 1f30567 Compare June 5, 2024 17:54
@j23414
Copy link
Contributor

j23414 commented Jun 5, 2024

Minor remark, I would add a link to the version of the pathogen-repo-guide (what standard you are conforming to) in your commit message:

For example:

Rename phylogenetic CI config file to standard name

Conforms to https://github.com/nextstrain/pathogen-repo-guide/blob/80cc1733b47f173772fe45005b82a69c6f8cb6c9/phylogenetic/defaults/config.yaml

@genehack
Copy link
Contributor Author

genehack commented Jun 5, 2024

Minor remark, I would add a link to the version of the pathogen-repo-guide (what standard you are conforming to) in your commit message:

For example:

Rename phylogenetic CI config file to standard name

Conforms to https://github.com/nextstrain/pathogen-repo-guide/blob/80cc1733b47f173772fe45005b82a69c6f8cb6c9/phylogenetic/defaults/config.yaml

I'm gonna die on the hill that using links to specific SHAs is an anti-pattern.

If we want to refer to stable versions of something, there should be a version tag applied to a SHA.

@genehack genehack merged commit fd634b5 into main Jun 5, 2024
32 checks passed
@genehack genehack deleted the standardize-config-name branch June 5, 2024 17:59
@j23414
Copy link
Contributor

j23414 commented Jun 5, 2024

I'm gonna die on the hill that using links to specific SHAs is an anti-pattern.

Haha, I won't die on this hill so feel free to leave out the link.

I've gotten used to adding a SHA pattern so if I get questions about why my commits don't match the pathogen-repo-guide (or X repo), I have more evidence than "I was matching an earlier version, but can't point to it".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants