Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use augur merge for sequences #76

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Dec 7, 2024

Description of proposed changes

Use our own tooling designed for this type of operation.

Related issue(s)

Checklist

Use our own tooling designed for this type of operation.
@victorlin victorlin self-assigned this Dec 7, 2024
@victorlin victorlin added the blocked Dependent on external development label Dec 7, 2024
Base automatically changed from victorlin/use-augur-merge to main December 9, 2024 19:59
@jameshadfield
Copy link
Member

This seems clear-cut for unsegmented pathogens, whereby we have a single augur merge command which collects all n metadata TSVs & m sequence FASTAs into a single TSV & FASTA.

For segmented genomes our analyses use a single TSV and 1 FASTA per segment. So the metadata includes samples which may be in only one FASTA (e.g. only one segment was sequenced). AFAIK we haven't got prototypes for how to merge multiple inputs for segmented pathogens beyond my prototype in avian-flu which handles metadata merging and sequence merging independently. It's not clear what's the best approach here.

We could continue to treat things independently. When augur merge is given both sequences & metadata does it do more than drop rows?

Should augur merge be aware of segments? e.g. you could specify something like --sequences usvi=seg1=<path> usvi=seg2=<path>.

@victorlin
Copy link
Member Author

@jameshadfield thanks for bringing that up. Replied in nextstrain/augur#1579 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Dependent on external development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants