Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] 12 No Attachment Placeholder #140

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

Conundraah
Copy link
Contributor

  • added a short note to the AttachmentView, if the list of attachments is empty

- added a short note to the AttachmentView, if the list of attachments is empty
@Conundraah Conundraah linked an issue Jul 29, 2024 that may be closed by this pull request
- change to build-and-publish.yml to resolve pyright type checking issues
@Conundraah Conundraah requested a review from Apollo3zehn July 29, 2024 11:37
@Conundraah Conundraah self-assigned this Jul 29, 2024
@Conundraah
Copy link
Contributor Author

I am not sure anymore what we defined as placeholder 😅. Is the message sufficient?

Copy link
Member

@Apollo3zehn Apollo3zehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no complaints, thanks! :-)

@Conundraah Conundraah merged commit 53045a3 into dev Jul 31, 2024
3 checks passed
@Conundraah Conundraah deleted the 12-no-attachment-placeholder branch July 31, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no attachment placeholder
2 participants