Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSL2: library merge #1043

Merged
merged 15 commits into from
Feb 2, 2024
Merged

DSL2: library merge #1043

merged 15 commits into from
Feb 2, 2024

Conversation

TCLamnidis
Copy link
Collaborator

@TCLamnidis TCLamnidis commented Jan 30, 2024 •
edited
Loading

Add Library merging SWF after Deduplication/Damage manipulation

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@TCLamnidis TCLamnidis changed the base branch from master to dev January 30, 2024 15:37
@TCLamnidis TCLamnidis closed this Jan 30, 2024
@TCLamnidis TCLamnidis reopened this Jan 30, 2024
@nf-core nf-core deleted a comment from github-actions bot Jan 30, 2024
@TCLamnidis TCLamnidis requested a review from a team January 30, 2024 15:40
@TCLamnidis
Copy link
Collaborator Author

I'm guessing linting fails have to do with the new template? I don't get all this red locally with nf-core tools 2.10

@jfy133
Copy link
Member

jfy133 commented Jan 30, 2024 •
edited
Loading

Correct, go do that template merge boy (jk <3 you)!

@jfy133
Copy link
Member

jfy133 commented Feb 2, 2024

@nf-core-bot fix linting

jfy133
jfy133 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisionally OK, but I think you're missing the single library skip re-routing

subworkflows/local/merge_libraries.nf Outdated Show resolved Hide resolved
subworkflows/local/merge_libraries.nf Outdated Show resolved Hide resolved
workflows/eager.nf Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit eaca1d5

+| ✅ 233 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗  20 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Include a figure that guides the user through the major workflow steps. Many nf-core
  • pipeline_todos - TODO string in README.md: Fill in short bullet-pointed list of the default steps in the pipeline
  • pipeline_todos - TODO string in nextflow.config: Specify your pipeline's command line flags
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in test.config: Specify the paths to your test data on nf-core/test-datasets
  • pipeline_todos - TODO string in test.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in test_humanbam.config: Specify the paths to your test data on nf-core/test-datasets
  • pipeline_todos - TODO string in test_humanbam.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in WorkflowEager.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • schema_description - No description provided in schema for parameter: skip_qualimap
  • schema_description - No description provided in schema for parameter: skip_damage_calculation

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.contamination_estimation_angsd_hapmap

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-02 12:27:05

@TCLamnidis TCLamnidis merged commit 63bf3e7 into dev Feb 2, 2024
16 checks passed
@TCLamnidis TCLamnidis deleted the dsl2_library_merge branch February 2, 2024 12:46
@TCLamnidis TCLamnidis linked an issue Mar 18, 2024 that may be closed by this pull request
DSL2: Add library merge step after damage_manipulation #1039
Closed
@TCLamnidis TCLamnidis mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DSL2: Add library merge step after damage_manipulation
2 participants
@TCLamnidis @jfy133