Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules.config #1099

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Update modules.config #1099

merged 4 commits into from
Nov 30, 2024

Conversation

TCLamnidis
Copy link
Collaborator

  • Removed enabled:true statements from publishDir directives.
  • Added exclusion of versions.yml from modules that lacked a publishDir.pattern
  • Moved preprocessing results into dedicated tool directories.
  • Corrected publishDir for BAM filtering process (preprocessing -> bam_filtering)
  • Minor formatting changes (indentation)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@TCLamnidis TCLamnidis requested a review from jfy133 November 29, 2024 14:44
@TCLamnidis
Copy link
Collaborator Author

lints fine with nf-core/tools version 2.14.1 locally. I suspect the failed linting is to do with template merge #1095

@TCLamnidis TCLamnidis merged commit 80ea23b into dev Nov 30, 2024
17 of 18 checks passed
@TCLamnidis TCLamnidis deleted the fix_publishdir branch November 30, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants