-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSL2: Add multi-reference mapping support #952
Conversation
Current to do:
|
@nf-core-bot fix linting |
Please rename |
I vote |
Next time: Continue updating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly documentation and spelling 🙇
Co-authored-by: Selina Carlhoff <[email protected]>
…sl2-indexing-multi
@nf-core-bot fix linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
-
ext.prefix
of (non-published) mapping output files should also include${meta.lane}
, since we map per lane, then merge! (No tests have one sample over multiple lanes as fasta input!!)- This should also apply to BAM -> FASTQ conversion, to avoid file name collisions.
- maybe add test with one-sample over multiple lanes?
- maybe
tag
should include library_id and lane also?
- Column vs entries missing in reference TSV. Are both optional? we should stick to clear nomenclature.
- replace
mitochondrion
tomitochondrion_header
in the docs. That was agreed as the name for the column. - Example reference TSV. If it's meant to be there, re-add it. if not, then rephrase.
- remove "notes prose" from parameter description.
Co-authored-by: Thiseas C. Lamnidis <[email protected]>
I've made all the changes @TCLamnidis , however you and @scarlhoff's stupid HapMap poop-gen files have now broken the tests again...
Following my previous notes to myself , there is a |
Should be fixed now, only needed to add the new reference sheet columns to the channel mapping adding a meta to the hapmap file. I also changed the test profile for angsd and mtnucratio CI tests to test_humanbam, so it will actually produce output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve pre-emptively cause the changes are very small now
-
Lane info should also be in the output name for BAM filtering output (for BAM input of the same library that only differs in lane number) - I think that for
test_humanbam
, the mt header should beMT
and notNC_007596.2
? I believe that bam was mapped to hs37d5. Please check annd adjust accordingly.
Decision: point 1 will be dealt with in a separate PR linked to this issue, because adding the attribute to the meta for BAM input could break downstream channel operations.
Adds ability to provide a TSV file listing multiple references and their correpsonding indicies etc.
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).