Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ALL gatk4 modules #6917

Merged
merged 77 commits into from
Nov 19, 2024
Merged

bump ALL gatk4 modules #6917

merged 77 commits into from
Nov 19, 2024

Conversation

matthdsm
Copy link
Contributor

@matthdsm matthdsm commented Oct 31, 2024

  • Bump GATK to v 4.6.1.0
  • Fix environment files
  • Add renovate comments
  • Move to wave containers
  • Add missing nf-tests
  • Fix broken tests
  • drop legacy test_data path
  • ...

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@matthdsm matthdsm requested a review from maxulysse as a code owner October 31, 2024 10:21
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but failing tests 😭

@matthdsm matthdsm requested a review from a team as a code owner November 4, 2024 12:49
@matthdsm matthdsm requested a review from edmundmiller November 4, 2024 12:49
@matthdsm matthdsm enabled auto-merge November 18, 2024 10:58
@matthdsm matthdsm disabled auto-merge November 19, 2024 08:50
@maxulysse
Copy link
Member

You sure about the process_single label?

@matthdsm
Copy link
Contributor Author

Yeah, I was looking at the cpu usage of our cluster and saw gatk using no more than one cpu at the time... I had a reservation of 80 cores of which only 8 were actively doing something....

@matthdsm
Copy link
Contributor Author

Anything with significant compression/decompression should have process_low

@matthdsm
Copy link
Contributor Author

If you don't trust it, feel free to revert the commit, we can always patch the modules in our pipelines

@nvnieuwk
Copy link
Contributor

Tests are passing locally and on gitpod, I got approval from Maxime to cowboy merge this in.

@edmundmiller do you think these CI issues can be fixed easily?

Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the instances where if the tests pass locally, we should ignore CI and not worry about getting it perfect. It's a guardrail but sometimes we can hop over it.

@edmundmiller edmundmiller merged commit 1999eff into nf-core:master Nov 19, 2024
11 of 26 checks passed
@matthdsm
Copy link
Contributor Author

Thank you for the faith @edmundmiller

@matthdsm matthdsm deleted the bump/gatk branch November 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants