-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump ALL gatk4 modules #6917
bump ALL gatk4 modules #6917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but failing tests 😭
You sure about the |
Yeah, I was looking at the cpu usage of our cluster and saw gatk using no more than one cpu at the time... I had a reservation of 80 cores of which only 8 were actively doing something.... |
Anything with significant compression/decompression should have process_low |
If you don't trust it, feel free to revert the commit, we can always patch the modules in our pipelines |
Tests are passing locally and on gitpod, I got approval from Maxime to cowboy merge this in. @edmundmiller do you think these CI issues can be fixed easily? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of the instances where if the tests pass locally, we should ignore CI and not worry about getting it perfect. It's a guardrail but sometimes we can hop over it.
Thank you for the faith @edmundmiller |
test_data
pathPR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda