-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Nextflow Versions #7019
Bump Nextflow Versions #7019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, nevermind I saw you changed the env variable
@@ -33,7 +35,7 @@ runs: | |||
- name: Install nf-test | |||
uses: nf-core/setup-nf-test@v1 | |||
with: | |||
version: "0.9.2" | |||
version: "${{ env.NFTEST_VERSION }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we use NFT_VERSION in other actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's what the renovate regex had by default. We could probably get away with VER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for NFT_VERSION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we use *_VER
because that's the default env name than NXF recognize, and we used NFT_VER to be coherent.
I'd rather NFT_VER, but I'm fine with whatever as long as use the same everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, sorry, meant NFT_VER
Fixes #6664